Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Swift 5 Migration #560

Closed
wants to merge 3 commits into from
Closed

Feat: Swift 5 Migration #560

wants to merge 3 commits into from

Conversation

baquer
Copy link
Member

@baquer baquer commented May 25, 2019

Fixes #539

Changes: Conversion to swift 5

Screenshots for the change:

N/A

@baquer
Copy link
Member Author

baquer commented May 25, 2019

@chashmeetsingh, @jogendra, Please Review the PR.

@baquer baquer changed the title Feat: Swift 5 conversion Feat: Swift 5 Migration May 25, 2019
@baquer
Copy link
Member Author

baquer commented May 25, 2019

@jogendra, after migrating to swift 5.0, the project is not building due to JI pod failure, as JI pod is not updated for swift 5.0.
I will look into it.

@baquer
Copy link
Member Author

baquer commented May 25, 2019

@jogendra, the project is building now by manually making changes in JI and Readabilitykit pod files. Any idea of how to make a permanent change in these pods?

@jogendra
Copy link
Member

@baquer If the pod is not in use, remove the Pod or find the good alternative. Otherwise, make a pull request to made changes in pod. The other thing we could do is make a fork to our org and make changes and use it but this is not the good way and I am not sure we will fork other repo in our org. @mariobehling could we do that?

@baquer
Copy link
Member Author

baquer commented Jun 14, 2019

@baquer If the pod is not in use, remove the Pod or find the good alternative. Otherwise, make a pull request to made changes in pod. The other thing we could do is make a fork to our org and make changes and use it but this is not the good way and I am not sure we will fork other repo in our org. @mariobehling could we do that?

@jogendra, I think by Changing the outdated pod to the latest pod is a better and long term solution.

@baquer
Copy link
Member Author

baquer commented Jun 14, 2019

I will make a PR soon for the new pods.

@baquer
Copy link
Member Author

baquer commented Jun 21, 2019

@jogendra the pods which I mentioned earlier are now updated to the latest version, now the project is building successfully without any errors. Please check it in your local repository too.
So should I change the pods or leave it here itself?

@jogendra
Copy link
Member

@baquer The circle-ci test is failing. PR cannot be reviewed/merge till it pass all the test. Please first pass all the test, test it well from your side then ping here.

@baquer
Copy link
Member Author

baquer commented Jun 23, 2019

@baquer The circle-ci test is failing. PR cannot be reviewed/merge till it pass all the test. Please first pass all the test, test it well from your side then ping here.

Okay, @jogendra I will try to fix the failing issue of circle ci.

@jogendra
Copy link
Member

jogendra commented Sep 8, 2019

Closing the PR due to inactivity. Feel free to open a new PR.

@jogendra jogendra closed this Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration to Swift 5.0
2 participants